fix : version picker to the API docs and highlight the overview as active#160
Open
ryzrr wants to merge 3 commits into
Open
fix : version picker to the API docs and highlight the overview as active#160ryzrr wants to merge 3 commits into
ryzrr wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avivkeller
reviewed
Jun 29, 2026
Comment on lines
+28
to
+31
| const versionItems = versions.map(version => ({ | ||
| value: `/docs/api/v${major(version)}.x`, | ||
| label: `v${major(version)}.x`, | ||
| })); |
Member
There was a problem hiding this comment.
this can go outside the function, right?
Member
Author
There was a problem hiding this comment.
it's already sits at the top of the component , so it is only build once when the file loads.
avivkeller
reviewed
Jun 29, 2026
…and-version-picker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the version picker and the fixup to make overview in the governance section as active (highlighted)
What kind of change does this PR introduce?
Fixes some Bug and one improvement
Did you add tests for your changes?
NO
Does this PR introduce a breaking change?
NO
If relevant, what needs to be documented once your changes are merged or what have you already documented?
NA
Use of AI
for the regex and testing